Some ContainerExec experimentation. #6481
Draft
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
added
the
NO-MERGE
|
I should note that PgAdmin allows you to backup and restore databases but the idea here is that you could do things like automate the restore of a database from a known baseline. |
davidfowl
reviewed
Oct 24, 2024
| var databases = e.Model.Resources.OfType<IResourceWithParent<PostgresServerResource>>().Where(r => r.Parent == builder.Resource).ToList(); | ||
| foreach (var db in databases) | ||
| { | ||
| var dbBuilder = builder.ApplicationBuilder.CreateResourceBuilder(db); |
There was a problem hiding this comment.
This super late model of mutating the resource builder is pretty broken... you know how I feel about this.
There was a problem hiding this comment.
This is BeforeStart. Not late at all.
There was a problem hiding this comment.
It is. At this point you should be adding the annotation directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something to look at post 9.0.
This is just a draft PR for some discussion. In the DCP types we have ContainerExec. It allows us to invoke a command against an existing container. I'm thinking it might enable us to do things like run backup/restore commands inside container images.
This would allow for some interesting advanced scenarios such as triggering a backup/restore of a postgres database using something like pg_dump within the container (the file would be copied to a databindmount.
@danegsta @karolz-ms @DamianEdwards @davidfowl @drewnoakes @JamesNK @adamint
Microsoft Reviewers: Open in CodeFlow