[release/9.0] Reject duplicate span ids #6471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
Duplicate span ids in a trace cause a Blazor error. The error UI is displayed and the page is no longer usable. It's no longer possible to span details.
Azure functions .NET SDK is producing bad data like this: #6441
This PR updates Aspire to reject the duplicate span id. This matches behavior of AzMon when it gets bad data.
NOTE: Co-incidentially this change was made in main branch a few days ago: #6262. The main PR makes more substantial changes. This PR just takes the duplicate span id fix.
Fixes #6441
Testing
Unit test added.
Manual test before:
Manual test after (span with duplicate id is removed):
Risk
Low.
Regression?
Yes. SpanId is now used as a grid row ID in Aspire 9. Previously both spans would have displayed.
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow