Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Reject duplicate span ids #6471

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 23, 2024

Customer Impact

Duplicate span ids in a trace cause a Blazor error. The error UI is displayed and the page is no longer usable. It's no longer possible to span details.

Azure functions .NET SDK is producing bad data like this: #6441

This PR updates Aspire to reject the duplicate span id. This matches behavior of AzMon when it gets bad data.

NOTE: Co-incidentially this change was made in main branch a few days ago: #6262. The main PR makes more substantial changes. This PR just takes the duplicate span id fix.

Fixes #6441

Testing

Unit test added.

Manual test before:
image

Manual test after (span with duplicate id is removed):
image

Risk

Low.

Regression?

Yes. SpanId is now used as a grid row ID in Aspire 9. Previously both spans would have displayed.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@joperezr
Copy link
Member

Regression. Low Risk. Fixing an issue likely to happen in a new scenario (Functions). Approved.

@joperezr joperezr merged commit 23bfd12 into release/9.0 Oct 24, 2024
9 checks passed
@joperezr joperezr deleted the jamesnk/9.0-reject-duplicate-spans branch October 24, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants