Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API cleanup from diff review #6305

Merged
merged 1 commit into from
Oct 15, 2024
Merged

API cleanup from diff review #6305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/ApplicationModel/EndpointNameAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Aspire.Hosting.ApplicationModel;
/// This API supports analyzers in Aspire.Hosting.Analyzers.
/// </remarks>
[AttributeUsage(AttributeTargets.Parameter, AllowMultiple = false)]
public class EndpointNameAttribute : Attribute, IModelNameParameter
public sealed class EndpointNameAttribute : Attribute, IModelNameParameter
{

}
6 changes: 3 additions & 3 deletions src/Aspire.Hosting/ApplicationModel/ResourceCommandAnnotation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public static class CommandResults
/// <summary>
/// The result of executing a command. Returned from <see cref="ResourceCommandAnnotation.ExecuteCommand"/>.
/// </summary>
public class ExecuteCommandResult
public sealed class ExecuteCommandResult
{
/// <summary>
/// A flag that indicates whether the command was successful.
Expand All @@ -144,7 +144,7 @@ public class ExecuteCommandResult
/// <summary>
/// Context for <see cref="ResourceCommandAnnotation.UpdateState"/>.
/// </summary>
public class UpdateCommandStateContext
public sealed class UpdateCommandStateContext
{
/// <summary>
/// The resource snapshot.
Expand All @@ -160,7 +160,7 @@ public class UpdateCommandStateContext
/// <summary>
/// Context for <see cref="ResourceCommandAnnotation.ExecuteCommand"/>.
/// </summary>
public class ExecuteCommandContext
public sealed class ExecuteCommandContext
{
/// <summary>
/// The service provider.
Expand Down
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/ApplicationModel/ResourceNameAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Aspire.Hosting.ApplicationModel;
/// This API supports analyzers in Aspire.Hosting.Analyzers.
/// </remarks>
[AttributeUsage(AttributeTargets.Parameter, AllowMultiple = false)]
public class ResourceNameAttribute : Attribute, IModelNameParameter
public sealed class ResourceNameAttribute : Attribute, IModelNameParameter
{

}
4 changes: 2 additions & 2 deletions src/Aspire.Hosting/ApplicationModel/WaitAnnotation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ namespace Aspire.Hosting.ApplicationModel;
/// <remarks>
/// The holder of this annotation is waiting on the resource in the <see cref="WaitAnnotation.Resource"/> property.
/// </remarks>
[DebuggerDisplay("Resource = {Resource.Name}")]
public class WaitAnnotation(IResource resource, WaitType waitType, int exitCode = 0) : IResourceAnnotation
[DebuggerDisplay("Type = {GetType().Name,nq}, Resource = {Resource.Name}")]
public sealed class WaitAnnotation(IResource resource, WaitType waitType, int exitCode = 0) : IResourceAnnotation
{
/// <summary>
/// The resource that will be waited on.
Expand Down