-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing port configuration to AddAzurePostgresFlexibleServer RunAsContainer #6276
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
@eerhardt Can you review? I think we want this for azure pg,sql and redis. cc @mitchdenny as well. |
To be consistent we'd probably have something like WithHostPort |
Are we going to do that for all containers? Just these 3? I Think we expose the actual container resource so that means WithHostPort will show up on all of these resources. |
I don't think the current PR code is want it this way. We don't have this builder.AddAzureCosmosDB("cosmos")
.RunAsEmulator(container =>
{
container.WithGatewayPort(9000);
});
builder.AddAzureStorage("storage")
.RunAsEmulator(configureContainer: builder =>
{
builder.WithBlobPort(9001);
builder.WithQueuePort(9002);
builder.WithTablePort(9003);
}); So instead, for PostgreSQL we should have: builder.AddAzurePostgresFlexibleServer("pgsql")
.RunAsContainer(configureContainer: builder =>
{
builder.WithHostPort(9004);
}); |
…ePostgresFlexibleServerResource
…stgresFlexibleServer-RunAsContainer
@eerhardt @mitchdenny Added requested changes for the PostgresServerResource. Some follow up questions:
|
@gabynevada apologies for the slow response here. I think we'll look to take this in 9.1. |
Description
The AddAzurePostgresFlexibleServer RunAsContainer does not have an exposed property to specify the running port like the AddPostgres method allows. This change adds the optional parameter to RunAsContainer and forwards it to the AddPostgres method used internally.
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow