-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health check support for Qdrant client #6057
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
// use http client for register health check | ||
var httpClientName = serviceKey is null ? "qdrant-healthchecks" : $"qdrant-healthchecks_{connectionName}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not implement this in Xabaril/AspNetCore.Diagnostics.HealthChecks#2186? Then everyone can use it, and not just people using the Aspire integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qdrant-client added health check method via qdrant/qdrant-dotnet#71. the latest version should have this method. I will try to use the client method instead of the current implementation in Aspire. also, I will update Xabaril PR to use this new health check method and we will update the existing aspire client to use the Xabaril package when the new health check package is released.
I still have this problem #6432 (comment) |
From the root of your repo, run the following and ensure you get the same output:
If any of those are disabled, make sure you enable them, usually in VS: |
Thanks a lot. |
Description
This PR Adds health check support for
Aspire.Qdrant.Client
.We need to import
Testcontainers
for ConformanceTests.Fixes #5768
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow