Skip to content

Commit

Permalink
Retry tests if msbuild crashes (#6181)
Browse files Browse the repository at this point in the history
* Retry tests if msbuild crashes

Issue: #6163

* Set MSBUILDDEBUGPATH to help with debugging crashes

* add comment
  • Loading branch information
radical authored Oct 21, 2024
1 parent 45898c6 commit cbc8773
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion eng/test-configuration.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"localRerunCount": 1,
"retryOnRules": [
{ "testName": { "contains": "Aspire.Elastic.Clients.Elasticsearch.Tests.ConformanceTests.HealthCheckReportsExpectedStatus" } },
{ "testAssembly": { "contains": "Aspire.Elastic.Clients.Elasticsearch.Tests" }, "failureMessage": { "contains": "RemoteExecutionException : Half-way through waiting for remote process." } }
{ "testAssembly": { "contains": "Aspire.Elastic.Clients.Elasticsearch.Tests" }, "failureMessage": { "contains": "RemoteExecutionException : Half-way through waiting for remote process." } },
{ "failureMessage" : { "contains" : "MSBUILD : error MSB4166: Child node" } }
]
}
3 changes: 3 additions & 0 deletions tests/helix/send-to-helix-inner.proj
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@
<!-- Disable playwright tests on helix/linux. Issue: https://github.com/dotnet/aspire/issues/4623 -->
<HelixPreCommand Condition="'$(DisablePlaywrightTests)' == 'true'" Include="$(_EnvVarSetKeyword) DISABLE_PLAYWRIGHT_TESTS=true" />

<!-- Issue: https://github.com/dotnet/aspire/pull/6181 -->
<HelixPreCommand Include="$(_EnvVarSetKeyword) MSBUILDDEBUGPATH=$(_HelixCorrelationPayloadEnvVar)/msbuild-debug" />

<HelixPreCommand Condition="'$(OS)' == 'Windows_NT'" Include="dotnet dev-certs https --trust" />

<HelixPostCommand Include="$(_CleanupProcessesCommand)" />
Expand Down

0 comments on commit cbc8773

Please sign in to comment.