blazor-crud scaffolder minor fixes #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvillan
approved these changes
Aug 22, 2024
guardrex
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Thanks @deepchoudhery ... I just see a handful of NIT suggestions.
WRT my Mackinnon ❓, I think you did the right thing making the properties private. I'll probably need to adjust our examples in the main doc set based on what he says.
WRT the primary ctor, no problem. I dealt with that one in the tutorial by not showing the code for it. It's free to change at any time without requiring a tutorial update later.
src/Scaffolding/VS.Web.CG.Mvc/Templates/RazorPageGenerator/Bootstrap4/EditPageModel.cshtml
Outdated
Show resolved
Hide resolved
src/Scaffolding/VS.Web.CG.Mvc/Templates/RazorPageGenerator/Bootstrap4/CreatePageModel.cshtml
Outdated
Show resolved
Hide resolved
src/Scaffolding/VS.Web.CG.Mvc/Templates/RazorPageGenerator/Bootstrap5/CreatePageModel.cshtml
Outdated
Show resolved
Hide resolved
src/dotnet-scaffolding/dotnet-scaffold-aspnet/Templates/BlazorCrud/Create.tt
Outdated
Show resolved
Hide resolved
src/dotnet-scaffolding/dotnet-scaffold-aspnet/Templates/BlazorCrud/Edit.cs
Outdated
Show resolved
Hide resolved
src/dotnet-scaffolding/dotnet-scaffold-aspnet/Templates/BlazorCrud/Edit.cs
Outdated
Show resolved
Hide resolved
src/dotnet-scaffolding/dotnet-scaffold-aspnet/Templates/BlazorCrud/Edit.tt
Outdated
Show resolved
Hide resolved
danroth27
reviewed
Aug 23, 2024
guardrex
reviewed
Aug 23, 2024
guardrex
reviewed
Aug 23, 2024
deepchoudhery
added a commit
that referenced
this pull request
Aug 27, 2024
* blazor-crud scaffolder minor fixes * PR comment fixes 1 * changing heading sequence * minor fix
deepchoudhery
added a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issues from #2743
builder.Services.AddQuickGridEntityFrameworkAdapter();: fixed earlier