fix issue with payload transfer and potential overread due to array p…

…ool buffer size
dotnet · Jul 4, 2024 · a3fb0fa · a3fb0fa
1 parent d60c7c0
commit a3fb0fa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Source/MQTTnet/Adapter/MqttChannelAdapter.cs b/Source/MQTTnet/Adapter/MqttChannelAdapter.cs
@@ -420,7 +420,7 @@ async Task<ReceivedMqttPacket> ReceiveAsync(CancellationToken cancellationToken)
         var bodyArray = mqttPacket.Body.Array;
         do
         {
-            var bytesLeft = bodyArray.Length - bodyOffset;
+            var bytesLeft = bodyLength - bodyOffset;
             if (chunkSize > bytesLeft)
             {
                 chunkSize = bytesLeft;

diff --git a/Source/MQTTnet/Buffers/MqttPayloadOwner.cs b/Source/MQTTnet/Buffers/MqttPayloadOwner.cs
@@ -11,7 +11,7 @@ namespace MQTTnet.Buffers
     /// Owner of <see cref="ReadOnlySequence{T}"/> that is responsible
     /// for disposing the underlying payload appropriately.
     /// </summary>
-    public struct MqttPayloadOwner<T> : IReadOnlySequenceOwner<T>
+    public class MqttPayloadOwner<T> : IReadOnlySequenceOwner<T>
     {
         public MqttPayloadOwner()
         {