Implement healthcheck endpoint for Lightsail #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joleeee
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Could also consider pulling in something like warp and just doing
#[tokio::main]
async fn main() {
// GET /hello/warp => 200 OK with body "Hello, warp!"
let hello = warp::path!("hello" / String)
.map(|name| format!("Hello, {}!", name));
warp::serve(hello)
.run(([127, 0, 0, 1], 3030))
.await;
}
joleeee
requested changes
Apr 1, 2024
| .await | ||
| .expect("Failed to start HTTP server"); | ||
| }); | ||
| futures::future::join_all(vec![app_handle, http_handle]).await; |
There was a problem hiding this comment.
also i think its very possible for the app to crash but this will wait forever for the http server to also stop, so perhaps not the best health check
There was a problem hiding this comment.
Yeah it's not really a good healthcheck, but Lightsail just needs a http endpoint on the service
|
Opened https://linear.app/dotkom/issue/DOT-696/reconfigure-tracing-subscriber-log-levels for tracking tracing levels |
joleeee
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could maybe use a proper http framework, but we just need to return a valid http message for AWS Lightsail recognize a healthy service.
Maybe in the future we can actually health-check the Slack websocket connection in this?