Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button for adding event to cal #683

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

henrikskog
Copy link
Contributor

@henrikskog henrikskog commented Aug 30, 2023

CLOSES: #672 (comment), #516

Hva som legges til

Vis knapp for å laste ned event-info til kalender på arrangementer bruker er meldt på.

Implementasjon

Laster ned ics-fil. Bruker api-endepunkt på ow4: old.online.ntnu.no/events/{id}.ics

Tar veeeeldig gjerne imot styling-feedback

image

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onlineweb-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:49pm

@henrikskog henrikskog changed the title Add button for adding event to cal DRAFT: Add button for adding event to cal Aug 30, 2023
@henrikskog henrikskog marked this pull request as draft August 30, 2023 19:41
@henrikskog henrikskog changed the title DRAFT: Add button for adding event to cal Add button for adding event to cal Aug 30, 2023
@henrikskog henrikskog marked this pull request as ready for review August 30, 2023 19:49
@henrikskog henrikskog linked an issue Aug 30, 2023 that may be closed by this pull request
@henrikskog henrikskog self-assigned this Aug 31, 2023
@junlarsen
Copy link
Member

Synes forsåvidt knapp stylinga ser grei ut. Eventuelt kan man prøve med samme styling på "Vis påmeldte" og denne siden begge er "secondary actions"

@henrikskog
Copy link
Contributor Author

henrikskog commented Aug 31, 2023

image

https://www.trondheimtechport.no/arrangementer/innovasjonsfrokost-4

Kom over denne påmeldingen. Synes det var en grei løsning egentlig. Jeg kommer ikke til å se på d nå, men til senere evt

Copy link
Member

@junlarsen junlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enig, LGTM

@henrikskog henrikskog merged commit 45098ea into master Aug 31, 2023
1 of 2 checks passed
@henrikskog henrikskog deleted the event-to-calendar-btn branch August 31, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants