-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump for doctrine orm 2 -> 3, dbal 3 -> 4 through roave psr container #283
Conversation
Qodana for PHP82 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why the uuid
column has moved towards the end of the table, before the created
column?
I guess Doctrine3 treats differently an entity when it extends another entity.
…gning AbstractEntity as MappedSuperclass for doctrine
Yes, because those columns comes from AbstractEntity, we need to declare this class with MappedSuperclass attribute, and if we want the |
…ll the lowest version
@alexmerlin The problem from github actions is dot-data-fixtures who request doctrine/data-fixtures ^1.5. support for orm 3 and dbal 4 was added from 1.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the good: updated
should get updated when the entity gets updated.
the bad: updated
should stay null
at entity creation.
@arhimede correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is not a tragedy if at the creation time, created and updated fields have the samr value
if this simplify the code, we should keep it that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second tought (or so)
We should not use ilogical stuff in database.
So at creation time, should be null the updated field
…res to support orm 3 and dbal 4
No description provided.