-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLUGINRANGERS-234 | Master file refactor step 8: Moved lib entities to src/Entity + minor adjustments #249
Merged
davidmolinacano
merged 26 commits into
master
from
davidmolinacano/pluginrangers/234/master_file_refactor_part_8
Oct 15, 2024
Merged
PLUGINRANGERS-234 | Master file refactor step 8: Moved lib entities to src/Entity + minor adjustments #249
davidmolinacano
merged 26 commits into
master
from
davidmolinacano/pluginrangers/234/master_file_refactor_part_8
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables to camelCase
davidmolinacano
changed the base branch from
master
to
davidmolinacano/pluginrangers/234/master_file_refactor_part_7
October 9, 2024 07:36
Base automatically changed from
davidmolinacano/pluginrangers/234/master_file_refactor_part_7
to
master
October 14, 2024 14:24
sofia-doofinder
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
yuloma
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surgically applied changes! 👨⚕️
davidmolinacano
deleted the
davidmolinacano/pluginrangers/234/master_file_refactor_part_8
branch
October 15, 2024 09:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by:
Now the folder structure follows the PrestaShop's standards: https://devdocs.prestashop-project.org/8/modules/creation/module-file-structure/#main-files-and-directories
Don't be afraid! 👻 There are too many files just because I renamed the folder, the actual lines changes are under 150 and most of them are namespaces