Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLUGINRANGERS-234 | Master file refactor step 8: Moved lib entities to src/Entity + minor adjustments #249

Conversation

davidmolinacano
Copy link
Contributor

@davidmolinacano davidmolinacano commented Oct 9, 2024

Required by:

Now the folder structure follows the PrestaShop's standards: https://devdocs.prestashop-project.org/8/modules/creation/module-file-structure/#main-files-and-directories

Don't be afraid! 👻 There are too many files just because I renamed the folder, the actual lines changes are under 150 and most of them are namespaces

@davidmolinacano davidmolinacano changed the base branch from master to davidmolinacano/pluginrangers/234/master_file_refactor_part_7 October 9, 2024 07:36
Base automatically changed from davidmolinacano/pluginrangers/234/master_file_refactor_part_7 to master October 14, 2024 14:24
@davidmolinacano davidmolinacano linked an issue Oct 14, 2024 that may be closed by this pull request
@davidmolinacano davidmolinacano self-assigned this Oct 14, 2024
@davidmolinacano davidmolinacano marked this pull request as ready for review October 14, 2024 15:30
Copy link
Member

@sofia-doofinder sofia-doofinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@yuloma yuloma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surgically applied changes! 👨‍⚕️

@davidmolinacano davidmolinacano merged commit e45f929 into master Oct 15, 2024
4 checks passed
@davidmolinacano davidmolinacano deleted the davidmolinacano/pluginrangers/234/master_file_refactor_part_8 branch October 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Est:5] [Prestashop] - Master file refactor
3 participants