Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix doofinder/dfcommon#963
this is somehow complex to explain:
doofinder/clickhousex
doesn't depend on agit
commit ofMint
, but rather on a particularmint
version. That would allow this project to be published0.4.0
but I won't merge this branch just yetstats
project can depend on this package (currently, it depends on this project viagit
), and it can itself be publiished, therefore doofinder/dfcommon#963 can be achievedstats
, depending onclickhouse 0.4.0
, which itself depends onmint 1.5.1
is ok, then I can merge this branch into the master, otherwise, to revert,stats
should be reverted to depend on thegit master
ofdoofinder/clickhouse
which itself (since we haven't merged the branch yet) depends ongit 8...
ofmint