Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarate/upgrade mint #1

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Zarate/upgrade mint #1

merged 2 commits into from
Oct 5, 2023

Conversation

JoeZ99
Copy link
Member

@JoeZ99 JoeZ99 commented Sep 28, 2023

fix doofinder/dfcommon#963

this is somehow complex to explain:

  • if this PR is approved, then this doofinder/clickhousex doesn't depend on a git commit of Mint, but rather on a particular mint version. That would allow this project to be published
  • so, if this PR is approved, then I'll publish this as a package with version 0.4.0 but I won't merge this branch just yet
  • if this is published as a package, then stats project can depend on this package (currently, it depends on this project via git), and it can itself be publiished, therefore doofinder/dfcommon#963 can be achieved
  • if stats , depending on clickhouse 0.4.0, which itself depends on mint 1.5.1 is ok, then I can merge this branch into the master, otherwise, to revert, stats should be reverted to depend on the git master of doofinder/clickhouse which itself (since we haven't merged the branch yet) depends on git 8... of mint

@agutierrezrodriguez
Copy link
Member

agutierrezrodriguez commented Sep 29, 2023

Only a question, We can't change to more up to date library like pillar?

@JoeZ99
Copy link
Member Author

JoeZ99 commented Sep 29, 2023

Only a question, We can't change to more up to date library like pillar?

I'm all for that. But I would do that after we stabilized things with clickhousex. When stats and dftasks works fine depending on this internal clickhousex hex package, I'd change it to pillar, because changing library probably means changing code a lot ...

@JoeZ99 JoeZ99 merged commit d856d99 into master Oct 5, 2023
@JoeZ99 JoeZ99 deleted the zarate/upgrade-mint branch October 5, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants