Fix tab-closing crash by middle mouse button (unexpected mouse position)

The TabBar.h getTabIndexAt(int x, int y) could fail to find the tab-index (the underlying TCM_HITTEST WM returns -1, when there is no tab at the current mouse position). Fix notepad-plus-plus#14328, close notepad-plus-plus#14329
donho · Nov 7, 2023 · 5b61cc1 · 5b61cc1
1 parent 1fafd0d
commit 5b61cc1
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/PowerEditor/src/WinControls/TabBar/TabBar.cpp b/PowerEditor/src/WinControls/TabBar/TabBar.cpp
@@ -849,7 +849,8 @@ LRESULT TabBarPlus::runProc(HWND hwnd, UINT Message, WPARAM wParam, LPARAM lPara
 			int xPos = LOWORD(lParam);
 			int yPos = HIWORD(lParam);
 			int currentTabOn = getTabIndexAt(xPos, yPos);
-			notify(TCN_TABDELETE, currentTabOn);
+			if (currentTabOn != -1)
+				notify(TCN_TABDELETE, currentTabOn);
 			return TRUE;
 		}