Merge pull request #2403 from dolanmiu/feature/bump-eslint-plugin

Upgrade @typescript-eslint/parser
dolanmiu · Nov 2, 2023 · f5f0218 · f5f0218
2 parents 8fbbd57 + 35702c3
commit f5f0218
Show file tree

Hide file tree

Showing 8 changed files with 71 additions and 175 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -72,7 +72,7 @@
         "@types/unzipper": "^0.10.4",
         "@types/xml": "^1.0.8",
         "@typescript-eslint/eslint-plugin": "^6.9.1",
-        "@typescript-eslint/parser": "^5.36.1",
+        "@typescript-eslint/parser": "^6.9.1",
         "@vitest/coverage-v8": "^0.33.0",
         "@vitest/ui": "^0.33.0",
         "cspell": "^7.3.8",

diff --git a/src/file/document/document.ts b/src/file/document/document.ts
@@ -80,6 +80,7 @@ export class Document extends XmlComponent {
     }
 
     public add(item: Paragraph | Table | TableOfContents | ConcreteHyperlink): Document {
+        // eslint-disable-next-line functional/immutable-data
         this.body.push(item);
         return this;
     }

diff --git a/src/file/paragraph/properties.ts b/src/file/paragraph/properties.ts
@@ -1,5 +1,6 @@
 // http://officeopenxml.com/WPparagraphProperties.php
 // https://c-rex.net/projects/samples/ooxml/e1/Part4/OOXML_P4_DOCX_suppressLineNumbers_topic_ID0ECJAO.html
+/* eslint-disable functional/immutable-data */
 import { IContext, IgnoreIfEmptyXmlComponent, IXmlableObject, OnOffElement, XmlComponent } from "@file/xml-components";
 import { DocumentWrapper } from "../document-wrapper";
 import { IShadingAttributesProperties, Shading } from "../shading";

diff --git a/src/file/paragraph/run/properties.ts b/src/file/paragraph/run/properties.ts
@@ -1,4 +1,5 @@
 // https://www.ecma-international.org/wp-content/uploads/ECMA-376-1_5th_edition_december_2016.zip page 297, section 17.3.2.21
+/* eslint-disable functional/immutable-data */
 import { BorderElement, IBorderOptions } from "@file/border";
 import { IShadingAttributesProperties, Shading } from "@file/shading";
 import { ChangeAttributes, IChangedAttributesProperties } from "@file/track-revision/track-revision";

diff --git a/src/file/xml-components/imported-xml-component.spec.ts b/src/file/xml-components/imported-xml-component.spec.ts
@@ -55,6 +55,7 @@ describe("ImportedXmlComponent", () => {
             otherAttr: "2",
         };
         importedXmlComponent = new ImportedXmlComponent("w:test", attributes);
+        // eslint-disable-next-line functional/immutable-data
         importedXmlComponent.push(new ImportedXmlComponent("w:child"));
     });
 

diff --git a/src/file/xml-components/imported-xml-component.ts b/src/file/xml-components/imported-xml-component.ts
@@ -21,6 +21,7 @@ export const convertToXmlComponent = (element: XmlElement): ImportedXmlComponent
             for (const childElm of childElements) {
                 const child = convertToXmlComponent(childElm);
                 if (child !== undefined) {
+                    // eslint-disable-next-line functional/immutable-data
                     xmlComponent.push(child);
                 }
             }
@@ -60,6 +61,7 @@ export class ImportedXmlComponent extends XmlComponent {
     public constructor(rootKey: string, _attr?: any) {
         super(rootKey);
         if (_attr) {
+            // eslint-disable-next-line functional/immutable-data
             this.root.push(new ImportedXmlComponentAttributes(_attr));
         }
     }

diff --git a/src/file/xml-components/xml-component.spec.ts b/src/file/xml-components/xml-component.spec.ts
@@ -20,11 +20,13 @@ describe("XmlComponent", () => {
         });
         it("should handle children elements", () => {
             const xmlComponent = new TestComponent("w:test");
+            // eslint-disable-next-line functional/immutable-data
             xmlComponent.push(
                 new Attributes({
                     val: "test",
                 }),
             );
+            // eslint-disable-next-line functional/immutable-data
             xmlComponent.push(new TestComponent("innerTest"));
 
             const tree = new Formatter().format(xmlComponent);
@@ -43,6 +45,7 @@ describe("XmlComponent", () => {
         });
         it("should hoist attrs if only attrs are present", () => {
             const xmlComponent = new TestComponent("w:test");
+            // eslint-disable-next-line functional/immutable-data
             xmlComponent.push(
                 new Attributes({
                     val: "test",