Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BASE_IMAGE param #990

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix BASE_IMAGE param #990

merged 1 commit into from
Feb 7, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Feb 6, 2024

The tests in GitHub and Azure DevOps have been modified to run using the latest Fedora by default, but it can be changed using the BASE_IMAGE param.

The GitHub tests have also been updated to reuse the images created by the build workflow. The build workflow has also been modified to store the images in a single cache instead of separate caches.

The runner-init.sh has been modified to use a positional argument to specify the container name and use jss-runner image by default.

https://github.com/dogtagpki/pki/wiki/Configuring-Test-OS

@edewata edewata requested a review from fmarco76 February 6, 2024 19:38
The tests in GitHub and Azure DevOps have been modified
to run using the latest Fedora by default, but it can be
changed using the BASE_IMAGE param.

The GitHub tests have also been updated to reuse the
images created by the build workflow. The build workflow
has also been modified to store the images in a single
cache instead of separate caches.

The runner-init.sh has been modified to use a positional
argument to specify the container name and use jss-runner
image by default.

https://github.com/dogtagpki/pki/wiki/Configuring-Test-OS
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@edewata
Copy link
Contributor Author

edewata commented Feb 6, 2024

I think the Rawhide build failure is caused by NSS changes on Rawhide (issue #991), not by this PR.

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Feb 7, 2024

@fmarco76 Thanks!

@edewata edewata merged commit 68a0df2 into dogtagpki:master Feb 7, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants