Merge pull request #271 from greg0ire/fix-dl

Fix definition list bug
doctrine · Jul 21, 2023 · 82f73b0 · 82f73b0
2 parents 06bc37c + 3677db5
commit 82f73b0
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/lib/Parser/DocumentParser.php b/lib/Parser/DocumentParser.php
@@ -309,7 +309,7 @@ private function parseLine(string $line): bool
                         return true;
                     }
 
-                    if ($this->lineChecker->isIndented($this->lines->getNextLine())) {
+                    if (trim($this->lines->getNextLine()) !== '' && $this->lineChecker->isIndented($this->lines->getNextLine())) {
                         $this->setState(State::DEFINITION_LIST);
                         $this->buffer->push($line);
 

diff --git a/tests/Functional/tests/render/definition-list/definition-list.html b/tests/Functional/tests/render/definition-list/definition-list.html
@@ -94,3 +94,13 @@ <h1>
         </dd>
     </dl>
 </div>
+<div class="section" id="not-a-definition-list">
+    <h1>
+        Not a definition list
+    </h1>
+    <p>Single line followed by a blank line</p>
+    <blockquote>
+        <p>This line is indented, but because of the blank line, it should
+not be considered a term. It is a blockquote.</p>
+    </blockquote>
+</div>
diff --git a/tests/Functional/tests/render/definition-list/definition-list.rst b/tests/Functional/tests/render/definition-list/definition-list.rst
@@ -84,3 +84,11 @@ term 1
     .. note::
 
         directive in definition list
+
+Not a definition list
+=====================
+
+Single line followed by a blank line
+
+    This line is indented, but because of the blank line, it should
+    not be considered a term. It is a blockquote.