BUG: When changing SQLFilter parameter, resulting SQL query is not generated correctly #11694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbannik
force-pushed
the
Bug-join-sql-when-change-sqlFilter-parameters
branch
from
6d81376
to
b3735ef
Compare
greg0ire
reviewed
Oct 22, 2024
|
Please improve your commit message according to the contributing guide. Most notably, please describe the bug, and explain how your changes address the issue. |
dbannik
force-pushed
the
Bug-join-sql-when-change-sqlFilter-parameters
branch
2 times, most recently
from
daad5e4
to
3717654
Compare
greg0ire
previously approved these changes
Oct 22, 2024
dbannik
force-pushed
the
Bug-join-sql-when-change-sqlFilter-parameters
branch
from
3717654
to
210ba6e
Compare
SenseException
previously approved these changes
Oct 22, 2024
|
🤔 why is this targeting 2.21.x? |
|
@greg0ire I don't know which branch to merge into |
|
Take a look at #11208 |
…ters CachedPersisterContext::$selectJoinSql should be clear or regenerated when sqlFilter changed The problem reproduce when in use fetch=EAGER and use additional sql filter on this property
dbannik
force-pushed
the
Bug-join-sql-when-change-sqlFilter-parameters
branch
from
210ba6e
to
439b4da
Compare
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
Draft
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
SenseException
approved these changes
Oct 23, 2024
|
Thanks @dbannik ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is not correctly generated sql when changed/switched sqlFilter parameters
CachedPersisterContext::$selectJoinSqlshould be clear or regenerated when sqlFilter changedThe problem reproduce when in use
fetch=EAGERand use additional sql filter on this property