Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve LSP violation #11520

Draft
wants to merge 2 commits into
base: 4.0.x
Choose a base branch
from
Draft

Resolve LSP violation #11520

wants to merge 2 commits into from

Conversation

greg0ire
Copy link
Member

This was necessary to support usage of static reflection, which is gone
with ORM 3.

This was necessary to support usage of static reflection, which is gone
with ORM 3.
@greg0ire
Copy link
Member Author

@stof Psalm now rightfully complains about this line:

$this->reflClass = $reflService->getClass($this->name);

What should I do?

More broadly, is https://github.com/doctrine/persistence/blob/3.3.x/src/Persistence/Mapping/StaticReflectionService.php still needed? Should null be removed from the return type of https://github.com/doctrine/persistence/blob/b337726451f5d530df338fc7f68dee8781b49779/src/Persistence/Mapping/ReflectionService.php#L51-L56 ?

@greg0ire
Copy link
Member Author

Related to doctrine/persistence#379

Copy link
Contributor

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Oct 15, 2024
@greg0ire
Copy link
Member Author

Looks like the issue I was concerned about was resolved in doctrine/persistence#381. I think I need to work on releasing persistence 4.0.0 before working on this 🤔

@github-actions github-actions bot removed the Stale label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant