Make PersistentCollection::first() "extra" lazy
#11035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
commented
Nov 2, 2023
tests/Doctrine/Tests/ORM/Functional/ExtraLazyCollectionTest.php
Outdated
Show resolved
Hide resolved
kbond
force-pushed
the
feat/lazy-first
branch
from
1d1781e
to
40c633d
Compare
|
@kbond its a really great addition. You should update |
kbond
force-pushed
the
feat/lazy-first
branch
from
40c633d
to
153333f
Compare
greg0ire
previously approved these changes
Nov 7, 2023
kbond
changed the title
PersistentCollection::first() "extra" lazyPersistentCollection::first() "extra" lazy
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
SenseException
previously approved these changes
Oct 20, 2024
beberlei
previously approved these changes
Oct 20, 2024
kbond
dismissed stale reviews from beberlei, SenseException, and greg0ire
via
c9253ef
kbond
force-pushed
the
feat/lazy-first
branch
from
153333f
to
c9253ef
Compare
✅ Done! |
greg0ire
approved these changes
Oct 21, 2024
|
Thanks @kbond ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's common to not want the entire collection loaded when calling
->first()on an extra-lazy collection.