-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PersistentCollection::first()
"extra" lazy
#11035
Conversation
tests/Doctrine/Tests/ORM/Functional/ExtraLazyCollectionTest.php
Outdated
Show resolved
Hide resolved
1d1781e
to
40c633d
Compare
@kbond its a really great addition. You should update |
40c633d
to
153333f
Compare
PersistentCollection::first()
"extra" lazyPersistentCollection::first()
"extra" lazy
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 but needs rebase onto 3.4.x
c9253ef
153333f
to
c9253ef
Compare
✅ Done! |
Thanks @kbond ! |
I think it's common to not want the entire collection loaded when calling
->first()
on an extra-lazy collection.