Cleanup bc layers #10741
Merged
Cleanup bc layers #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
cleanup-bc-layers
branch
from
e9dbfbf
to
f3f0acf
Compare
lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php
Outdated
Show resolved
Hide resolved
The linked issue has been addressed, this rules should have been removed during a merge up, as it is no longer present on 2.x
That property has been removed from 3.0.x
Note that we also remove UpdateCommandTest::testItPrintsTheSql() because it relied on not passing --complete to work.
greg0ire
force-pushed
the
cleanup-bc-layers
branch
from
845f20c
to
0945f60
Compare
derrabus
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we also remove
UpdateCommandTest::testItPrintsTheSql()becauseit relied on not passing --complete to work.