Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Review cookbook on blending ORM and ODM #2656

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 26, 2024

Q A
Type doc
BC Break no
Fixed issues -

Summary

  • Add tests for this documentation
  • Add type to properties

@GromNaN GromNaN changed the title Review cookbook on blending ORM and ODM doc: Review cookbook on blending ORM and ODM Jun 26, 2024
@GromNaN GromNaN added this to the 2.9.0 milestone Jun 27, 2024
@GromNaN GromNaN requested a review from alcaeus July 1, 2024 09:04
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text still reads a little rough, but it's fine to leave as is and making sure the functionality described works as expected. We can give this doc a more thorough makeover in a separate stage.

@GromNaN
Copy link
Member Author

GromNaN commented Jul 1, 2024

I rewrote the introduction.

@GromNaN GromNaN enabled auto-merge (squash) July 1, 2024 13:41
@GromNaN GromNaN merged commit 5719573 into doctrine:2.9.x Jul 1, 2024
17 of 18 checks passed
@GromNaN GromNaN deleted the doc-blending-orm branch July 1, 2024 15:57
alcaeus added a commit that referenced this pull request Sep 6, 2024
* 2.9.x: (24 commits)
  Fix typo in code example (#2670)
  Label PRs about GH actions with "CI" (#2632)
  Review basic mapping (#2668)
  Fix wording (#2667)
  Add native type to private properties and final classes (#2666)
  Review and add tests on `ResolveTargetDocumentListener` (#2660)
  Remove soft-delete-cookbook (#2657)
  doc: Remove wakeup and clone cookbook (#2663)
  Modernize generated code for Hydrators (#2665)
  Add tests for introduction (#2664)
  doc: Review mapping ORM and ODM cookbook (#2658)
  doc: Review cookbook on blending ORM and ODM (#2656)
  doc: Review and test validation cookbook (#2662)
  Update custom mapping example (#2654)
  doc: Review Simple Search Engine Cookbook (#2659)
  doc: Add cookbook about embedding referenced documents using $lookup (#2655)
  doc: Add type to properties (#2652)
  doc: Review custom collections and repository docs (#2653)
  doc: Review Getting Started (#2650)
  Move annotations-reference to attributes-reference (#2651)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants