Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Removed strict xml validation] #2535

Open
wants to merge 1 commit into
base: 2.10.x
Choose a base branch
from
Open

[Removed strict xml validation] #2535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Doctrine/ODM/MongoDB/Mapping/Driver/XmlDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ private function validateSchema(string $filename): void
libxml_clear_errors();

if (! $document->schemaValidate(__DIR__ . '/../../../../../../doctrine-mongo-mapping.xsd')) {
throw MappingException::xmlMappingFileInvalid($filename, $this->formatErrors(libxml_get_errors()));
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes feature altogether instead of letting user opt-out of it. There should be a flag passed to XmlDriver::__construct that defaults to true so current behaviour is preserved.

Also version 2.2.x that you're targeting is no longer maintained. This technically is a feature so 2.6.x branch should be targeted although we may consider releasing as a bugfix version (depending on where we'll end with configurating opt-out).

}
} finally {
libxml_use_internal_errors($previousUseErrors);
Expand Down