Add exception for invalid value from the database

doctrine · Jun 26, 2024 · 827f613 · 827f613
1 parent 94a6fc5
commit 827f613
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/docs/en/reference/custom-mapping-types.rst b/docs/en/reference/custom-mapping-types.rst
@@ -43,8 +43,8 @@ a ``DateTimeImmutable`` when the data is read from the database.
 
         public function convertToDatabaseValue($value): array
         {
-            if (! is_array($value) || ! isset($value['utc'], $value['tz'])) {
-                throw new Exception(); // TODO: throw correct exception class
+            if (! isset($value['utc'], $value['tz'])) {
+                throw new RuntimeException('Database value cannot be converted to date with timezone. Expected array with "utc" and "tz" keys.');
             }
 
             return [

diff --git a/tests/Documentation/CustomMapping/DateTimeWithTimezoneType.php b/tests/Documentation/CustomMapping/DateTimeWithTimezoneType.php
@@ -10,6 +10,7 @@
 use Doctrine\ODM\MongoDB\Types\ClosureToPHP;
 use Doctrine\ODM\MongoDB\Types\Type;
 use MongoDB\BSON\UTCDateTime;
+use RuntimeException;
 
 class DateTimeWithTimezoneType extends Type
 {
@@ -19,6 +20,10 @@ class DateTimeWithTimezoneType extends Type
     /** @param array{utc: UTCDateTime, tz: string} $value */
     public function convertToPHPValue($value): DateTimeImmutable
     {
+        if (! isset($value['utc'], $value['tz'])) {
+            throw new RuntimeException('Database value cannot be converted to date with timezone. Expected array with "utc" and "tz" keys.');
+        }
+
         $timeZone = new DateTimeZone($value['tz']);
         $dateTime = $value['utc']
             ->toDateTime()