Non-nullable

doctrine · Jun 26, 2024 · 31708c8 · 31708c8
1 parent 868924c
commit 31708c8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/docs/en/reference/custom-mapping-types.rst b/docs/en/reference/custom-mapping-types.rst
@@ -31,7 +31,7 @@ a ``DateTimeImmutable``.
         // This trait provides default closureToPHP used during data hydration
         use ClosureToPHP;
 
-        public function convertToPHPValue($value): ?DateTimeImmutable
+        public function convertToPHPValue($value): DateTimeImmutable
         {
             $timeZone = new DateTimeZone($value['tz']);
             $dateTime = $value['utc']
@@ -41,7 +41,7 @@ a ``DateTimeImmutable``.
             return DateTimeImmutable::createFromMutable($dateTime);
         }
 
-        public function convertToDatabaseValue($value): ?array
+        public function convertToDatabaseValue($value): array
         {
             return [
                 'utc' => new UTCDateTime($value),

diff --git a/tests/Documentation/CustomMapping/DateTimeWithTimezoneType.php b/tests/Documentation/CustomMapping/DateTimeWithTimezoneType.php
@@ -5,6 +5,7 @@
 namespace Documentation\CustomMapping;
 
 use DateTimeImmutable;
+use DateTimeInterface;
 use DateTimeZone;
 use Doctrine\ODM\MongoDB\Types\ClosureToPHP;
 use Doctrine\ODM\MongoDB\Types\Type;
@@ -15,7 +16,10 @@ class DateTimeWithTimezoneType extends Type
     // This trait provides default closureToPHP used during data hydration
     use ClosureToPHP;
 
-    public function convertToPHPValue($value): ?DateTimeImmutable
+    /**
+     * @param array{utc: UTCDateTime, tz: string} $value
+     */
+    public function convertToPHPValue($value): DateTimeImmutable
     {
         $timeZone = new DateTimeZone($value['tz']);
         $dateTime = $value['utc']
@@ -25,7 +29,12 @@ public function convertToPHPValue($value): ?DateTimeImmutable
         return DateTimeImmutable::createFromMutable($dateTime);
     }
 
-    public function convertToDatabaseValue($value): ?array
+    /**
+     * @param DateTimeInterface $value
+     *
+     * @return array{utc: UTCDateTime, tz: string}
+     */
+    public function convertToDatabaseValue($value): array
     {
         return [
             'utc' => new UTCDateTime($value),