Update PHPStan to 1.12 #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Sep 9, 2024
Comment on lines
82
to
84
| preg_match('/<p>{{ DOCS_SOURCE_PATH : (.*) }}<\/p>/', $contents, $match); | ||
|
|
||
| assert(count($match) === 2); |
There was a problem hiding this comment.
Asserting that the regex did actually match should also narrow the match array enough.
Suggested change
| preg_match('/<p>{{ DOCS_SOURCE_PATH : (.*) }}<\/p>/', $contents, $match); | |
| assert(count($match) === 2); | |
| $result = preg_match('/<p>{{ DOCS_SOURCE_PATH : (.*) }}<\/p>/', $contents, $match); | |
| assert($result === 1); |
There was a problem hiding this comment.
It does. I didn't expect that phpstan can work with the return value to handle the matches.
SenseException
force-pushed
the
phpstan212
branch
2 times, most recently
from
715e024
to
3e4ca60
Compare
|
It's 1.12, not 2.12. 🤓 |
SenseException
force-pushed
the
phpstan212
branch
from
3e4ca60
to
395f5e7
Compare
|
It was a PR from the future, but I downgraded the version to the one that is known to the current time. 😇 |
derrabus
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.