JS GitHub workflows #508
Merged
JS GitHub workflows #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should |
|
That would look like in the recent commit. |
greg0ire
reviewed
Aug 26, 2023
greg0ire
reviewed
Aug 26, 2023
SenseException
force-pushed
the
js-workflows
branch
from
7e85856
to
41caabf
Compare
derrabus
approved these changes
Aug 27, 2023
greg0ire
approved these changes
Aug 27, 2023
| runs-on: "ubuntu-latest" | ||
|
|
||
| steps: | ||
| - uses: "actions/checkout@v2" |
There was a problem hiding this comment.
Suggested change
| - uses: "actions/checkout@v2" | |
| - uses: "actions/checkout@v3" |
| runs-on: "ubuntu-latest" | ||
|
|
||
| steps: | ||
| - uses: "actions/checkout@v2" |
There was a problem hiding this comment.
Suggested change
| - uses: "actions/checkout@v2" | |
| - uses: "actions/checkout@v3" |
|
Approving in case you used "v2" in order to be consistent with other workflows, and plan to switch all workflows to v3 in another PR. |
SenseException
force-pushed
the
js-workflows
branch
from
41caabf
to
f7b7ee1
Compare
Revisiting the workflows wasn't at the top of my todo list, but I can do at least update versions in a new PR in one of my next PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.