Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to deal with checks #481

Merged
merged 1 commit into from
May 29, 2023

Conversation

greg0ire
Copy link
Member

This addresses question 2 and 3 from #472

@greg0ire greg0ire force-pushed the how-to-deal-with-checks branch 3 times, most recently from e1342b3 to 2ee40ff Compare May 28, 2023 18:11
@greg0ire
Copy link
Member Author

@mpdude please review.

This addresses question 2 and 3 from doctrine#472
@mpdude
Copy link

mpdude commented May 29, 2023

Excellent. Thanks!

@SenseException SenseException merged commit a009d28 into doctrine:master May 29, 2023
@SenseException
Copy link
Member

Thanks @greg0ire and thank you @mpdude for taking a look on this from a fresh perspective.

@greg0ire greg0ire deleted the how-to-deal-with-checks branch May 29, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants