-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base update to PHP 8.2 #476
Conversation
2fcd2fa
to
a5bb9cf
Compare
The update is pretty much close to the end, but generating the docs end in multiple errors based on the outdated rst format of the doc-files, especially
I don't know how the docs will look like either until I manage a docs-build without exceptions. |
Might be because of the linebreak right in the middle of a link? There's only one occurrence of |
Cc @linawolf in case you think this might be a bug in the parser, or in case linebreaks in the middle of a link are invalid. |
When I remove doctrine/data-fixtures from the build then the next project is affected by the same error. In my case |
🤔 no occurrence of |
There needs to be a new line after |
I created doctrine/data-fixtures#428 to address this on the data-fixtures repo. |
I'm not sure if this error is connected to the rst-parser. The html file already exists and contains html+twig code, so the rst got parsed. |
Should you maybe add
|
The workflow breaks earlier because of the dbal table I mentioned in a comment earlier, but I already got myself a stack-trace on my local machine. I'd expect a Twig error, but I haven't pinned it down to the actual cause. This file contains the complete output of one of my test runs. (I skipped the Exceptions of the dbal tables) |
Looking at that stack trace, I think it might be about this line:
Of maybe this one:
|
The failure seems to relate to doctrine/dbal#5197 |
But if we had to reuse this commit on lower branches, well there are a lot of branches to backport it to: https://github.com/doctrine/dbal/blob/3.6.x/.doctrine-project.json I don't understand why this wasn't an issue sooner 🤔 UPDATE: ah that's probably the update of the RST Parser |
Yes, it's the newer versions of the rst-parser. It's breaking the website build in the latest 0.5 release and the 0.6 branch. I've created an issue that described the behavior of one of the errors a long time ago, but I don't find it anymore and I'm not sure yet if it's the same issue again. Once my workstation is ready to use, I can resume my work. |
There's also an exception on ORM, but I haven't confirmed yet if this has something to do with rst tables. |
Looks like ORM and DBAL are the only ones that cause the build to break now. If I skip/ignore these, then the build runs to the end and I can see the website with its docs (minus the versions that cause the problems) ORMhttps://github.com/doctrine/rst-parser/blob/0.5.x/lib/Parser/LineDataParser.php#L177-L179 These lines are the ones that are involved in the ORM build failure "Warning: Undefined array key 0". DBALThe newer versions work fine. 3.3 is the last version that gets its docs generated, but 3.2 is the first in line that causes the build to break. The trace of the exception in my previous comment reduces the source of this error to the types-table. A diff between 3.3 and 3.2 shows an indent of the table and reference fixes as the only changes. |
With 2.12.x, that sentence is preceded with a seemingly empty line. Seemingly, because it in fact has trailing whitespace (3 spaces). It would be interesting to push a commit removing that trailing whitespace to 2.12.x and see what happens. |
I came to the same conclusion, because |
Yes and I think the fix will be to change line 312 of EDIT: or maybe not. I cannot reproduce the bug, and the change above breaks the test suite 😞 |
Ah hang on, if I copy paste the file literally, I do reproduce the issue. I'll try reducing it to what's strictly necessary. |
The magical formula is:
|
Oh and my fix works. I must have copy/pasted it wrong last attempt. |
Before converting this draft to a PR, and therefore before merging this, We have to test the website on staging. I did a deployment yesterday, but for yet unknown reasons, some versions are missing in the dbal docs. There are probably other projects affected too. This needs to be checked if this issue is connected to the updates of this branch. |
The first step is the update of the website dependencies. After that refactorings and rewrites need to be done.
This is an unfavorable workaround to progress the update to php 8.2
Let's do this 💪 |
Thanks and congrats @SenseException !!! |
Great work! |
This PR is for the plain update to PHP 8.2 with its composer dependencies. Refactorings and rewrites aren't included in this step.