Cover scenario BEGIN TRANSACTION; COMMIT; BEGIN TRANSACTION; --failure
#6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
changed the title
simPod
changed the title
BEGIN TRANSACTION; COMMIT; BEGIN TRANSACTION; --failure
greg0ire
reviewed
Oct 20, 2024
simPod
force-pushed
the
cover-failure
branch
2 times, most recently
from
30ead0b
to
0e2fa82
Compare
greg0ire
reviewed
Oct 20, 2024
greg0ire
approved these changes
Oct 20, 2024
SenseException
approved these changes
Oct 20, 2024
derrabus
pushed a commit
that referenced
this pull request
Oct 21, 2024
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | <!-- use #NUM format to reference an issue --> #### Summary _This is a followup of https://github.com/doctrine/dbal/pull/6558_, I have touched only what previous PR touched. @greg0ire [requested](#6562 (review)) to use stubs where there are no expectations 
morozov
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Covers the concern expressed by @greg0ire #6545 (comment)
Transaction should not be rolled back in autocommit=false mode when
BEGIN TRANSACTIONfails due to network error or similar afterCOMMIT.