Simplify tracking implicitly created indexes #6550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to clean up the codebase before reworking the logic of managing indexes in the schema.
Currently,
Table::$implicitIndexes
contains both the index names as keys and the indexes themselves as values. On the one hand, this is redundant (because all indexes are already contained inTable::$_indexes
); on the other hand, this is confusing (it is unclear whetherTable::$_indexes
contains all indexes or only the explicitly created ones).The proposed fix replaces
Table::$implicitIndexes
withTable::$implicitIndexNames
and addresses both of the above issues.Additionally, it introduces the
PrimaryKeyAlreadyExists
exception. This isn't strictly necessary here but also addresses two issues: