fix: TableDiff deprecation points to wrong method #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jan 22, 2024
derrabus
approved these changes
Jan 22, 2024
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jan 25, 2024
)" This reverts commit 06d9e9f.
derrabus
added a commit
that referenced
this pull request
Jan 25, 2024
This PR reverts PR #6080 and its follow-up #6273. Merging this feature up to 4.0 is more difficult that I anticipated and I don't want to postpone the release of 3.8 and 4.0 any further. @Tofandel: Please take all the time that you need to redo your PR on 4.x. As soon as you did that, I'd be more than happy to restore this change and do another 3.x feature release.
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jan 25, 2024
* 3.8.x: Revert the rename column feature (doctrine#6276) fix: TableDiff deprecation points to wrong method (doctrine#6273) Stop using chocolatey shims (doctrine#6269) Add explicit renameColumn method for Table (doctrine#6080)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6080
While preparing the merge request to port to 4.0.x I found that some comments point to a deprecated method (one even points to itself)
I also found that in DB2 the reorg happens even if there is no query running which was a bit weird and adding column was not triggering a reorg which is wrong and was not picked up by tests (because other changed columns triggered it)