Unset statement resource in bindValue

[epistemery]

Fix odbc issue #6088

Q	A
Type	bug/feature/improvement
Fixed issues	#6088

Summary

Reset statement resource after call to bindValue

[derrabus]

Thank you. Please add a functional test that reproduces your issue and thus covers your change.

[epistemery]

I've added a test case based on my description of #6088 , but could not find documentation on how to run the sqlsrv test cases, so I could not verify that the test is working as expected. Do you have documentation on how to run the tests for specific platforms?

[derrabus]

Do you have documentation on how to run the tests for specific platforms?

You need a local database server obviously. All you need to do then is create a custom PHPUnit configuration with the credentials to your database. You'll find some examples in the ci/github/phpunit directory. Those are the configuration files that we use for our CI.

[derrabus]

Tests are failing btw.

[epistemery]

Tests should pass now. But another thing I've noticed is that I can reproduce the error in the context of a Symfony app, but not within a test case of doctrine/dbal. Meaning, the test passes with and without the fix in Statement.php.

A similar test fails (with same connection params and with config = eventManager = null) when having doctrine/dbal installed in the context of a Symfony application.

One other thing I've realized is, that is has something to do with encoding. I have to do some further debugging to find out what's causing this issue.

[derrabus]

Do you know str_repeat()?

[derrabus]

Meaning, the test passes with and without the fix in Statement.php.

Then it's not a valid test for your change, sorry.

[epistemery]

Correct, this is not a valid test case. I was finally able to do some testing and it seems the culprit is sqlsrv extension < 5.11. I thought I was testing it with 5.11, but due to some docker caching magic I had 5.10 in the original setup, and 5.11 in my dbal testing setup.

Although this pull fixes it for sqlsrv version 5.10, my guess is that you do not want to merge, so I'm closing this PR. I'll add a note in #6088 for anyone who needs 5.10 and needs a workaround.