Add rename loop case

doctrine · Aug 29, 2023 · d27d676 · d27d676
1 parent 09a504b
commit d27d676
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Schema/Table.php b/src/Schema/Table.php
@@ -380,7 +380,9 @@ final public function renameColumn(string $oldName, string $newName): Column
             unset($this->renamedColumns[$toRemove]);
         }
 
-        $this->renamedColumns[$newName] = $oldName;
+        if ($newName !== $oldName) {
+            $this->renamedColumns[$newName] = $oldName;
+        }
 
         return $column;
     }

diff --git a/tests/Schema/TableTest.php b/tests/Schema/TableTest.php
@@ -85,6 +85,17 @@ public function testRenameColumnException(): void
         $table->renameColumn('baz', 'Baz');
     }
 
+    public function testRenameColumnLoop(): void
+    {
+        $table = new Table('foo');
+        $table->addColumn('baz', Types::INTEGER);
+        $table->renameColumn('baz', 'foo');
+        self::assertCount(1, $table->getRenamedColumns());
+        $table->renameColumn('foo', 'baz');
+        self::assertCount(1, $table->getColumns());
+        self::assertCount(0, $table->getRenamedColumns());
+    }
+
     public function testColumnsCaseInsensitive(): void
     {
         $table  = new Table('foo');