Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce EnvironmentAwareMigrationInterface #530

Open
wants to merge 5 commits into
base: 3.4.x
Choose a base branch
from

Conversation

alexndlm
Copy link

@alexndlm alexndlm commented Mar 22, 2024

In migrations, it's best to avoid using dynamic values or services that could cause unexpected issues. However, including the current environment can be really helpful. It lets us skip migrations for testing or production and set different default values depending on the environment.

@alexndlm alexndlm closed this Mar 22, 2024
@alexndlm alexndlm deleted the feature/introduce-EnvironmentAwareMigrationInterface branch March 22, 2024 17:06
@alexndlm alexndlm restored the feature/introduce-EnvironmentAwareMigrationInterface branch March 23, 2024 19:21
@alexndlm alexndlm reopened this Mar 23, 2024
@alexndlm
Copy link
Author

@derrabus wdyt?

@greg0ire
Copy link
Member

It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those.

@alexndlm
Copy link
Author

@greg0ire, thanks, fixed.

@greg0ire
Copy link
Member

Blocked by #531

@greg0ire greg0ire changed the base branch from 3.3.x to 3.4.x March 25, 2024 13:29
@greg0ire greg0ire closed this Mar 25, 2024
@greg0ire greg0ire reopened this Mar 25, 2024
@greg0ire
Copy link
Member

Retargeting to 3.4.x since this is no bugfix

@ERuban
Copy link

ERuban commented Jul 1, 2024

Any news on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants