Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing database "name" (=path) for SQLite #359

Open
wants to merge 1 commit into
base: 3.4.x
Choose a base branch
from

Conversation

ThomasLandauer
Copy link
Contributor

Since DBAL 3.0 (see doctrine/migrations#1028), the message currently reads for SQLite:

Careful, database "" will be purged. Do you want to continue? (yes/no)

Neither @Ocramius (see doctrine/dbal#3606 (comment)) nor me (see doctrine/dbal#4982) succeeded in convincing @morozov to continue returning the file path ;-) So it looks like the fix needs to be done here...

Suggestion: What about adding the platform too? So the message would be:

Careful, MySQL database "foo" will be purged. Do you want to continue? (yes/no)

BTW: doctrine/migrations is currently broken too:

WARNING! You are about to execute a migration in database "" that could result in schema changes and data loss. Are you sure you wish to continue? (yes/no) [yes]:

So when done here, I'm going to submit the same there (i.e. follow up of doctrine/migrations#1028)

Since DBAL 3.0 (see doctrine/migrations#1028), the message currently reads for SQLite:
> Careful, database "" will be purged. Do you want to continue? (yes/no)

Neither @Ocramius (see doctrine/dbal#3606 (comment)) nor me (see doctrine/dbal#4982) succeeded in convincing @morozov to continue returning the file path ;-) So it looks like the fix needs to be done here...

Suggestion: What about adding the platform too? So the message would be:
> Careful, MySQL database "foo" will be purged. Do you want to continue? (yes/no)

`doctrine/migrations` is currently broken too:

> WARNING! You are about to execute a migration in database "<unnamed>" that could result in schema changes and data loss. Are you sure you wish to continue? (yes/no) [yes]:

So when done here, I'm going to submit the same there  (i.e. follow up of doctrine/migrations#1028)
@morozov
Copy link
Member

morozov commented Nov 11, 2021

@ThomasLandauer please avoid mentioning people or using links to GitHub issues in commit messages. People will get spammed every time this commit is rebased or amended, and the GitHub resources will get linked to each of the rebased or otherwise amended versions.

@ThomasLandauer
Copy link
Contributor Author

Sorry, didn't know that! So it's OK in the PR message (tab "Conversation" on GitHub's website) but not in the message when doing the actual file change (tab "Commits")?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants