Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

go mod: use docker/docker@master instead of docker/engine snapshot (Take 2) #530

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CpuID
Copy link
Contributor

@CpuID CpuID commented Aug 14, 2019

To avoid conflicts when importing in other projects (dependency hell
between docker/docker vs docker/engine).

On an external project, I'd get errors like this without this PR:

$ go get github.com/docker/libcompose@master
go: finding github.com/docker/libcompose master
go: finding github.com/docker/docker v0.0.0-00010101000000-000000000000
go: github.com/docker/[email protected]: unknown revision 000000000000

cc @vdemeester


My 2c: In an ideal world everything would use one repo reference (either docker/engine OR docker/docker), and personally I'd almost suggest docker/engine is cleaner due to no moby/moby rename, but I'm not a decision maker on Docker development and keeping a single canonical import is the safe answer right now across the Go ecosystem.

avoid conflicts when importing in other projects (dependency hell between
docker/docker vs docker/engine)

Signed-off-by: Nathan Sullivan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant