This repository has been archived by the owner on Jun 16, 2021. It is now read-only.
go mod: use docker/docker@master instead of docker/engine snapshot (Take 2) #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid conflicts when importing in other projects (dependency hell
between
docker/docker
vsdocker/engine
).On an external project, I'd get errors like this without this PR:
cc @vdemeester
My 2c: In an ideal world everything would use one repo reference (either
docker/engine
ORdocker/docker
), and personally I'd almost suggestdocker/engine
is cleaner due to nomoby/moby
rename, but I'm not a decision maker on Docker development and keeping a single canonical import is the safe answer right now across the Go ecosystem.