engine/install: sync between distros, use dnf for RHEL and CentOS, and some touch-ups
#21384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
requested changes
Nov 8, 2024
dvdksn
previously approved these changes
Nov 8, 2024
thaJeztah
force-pushed
the
sync_install
branch
from
bf6c578
to
05dfdfc
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Unlike deb-based systems, installing an rpm doesn't automatically start the Docker service, and starting the service doesn't make it automatically start on (re)boot. Update the instructions so that Docker is automatically started on boot. follow-up to 1514b0d, which left some of the old instructions. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Make it more clear we're starting the engine (not "docker", the CLI). Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use interactive installation for packages from our repository, so that the user can confirm what will be installed. For the distro-packages (yum-utils), we keep the non-interactive, as these should be generally ok to install. follow-up to fde4750 Signed-off-by: Sebastiaan van Stijn <[email protected]>
The versions of CentOS and RHEL we support now have dnf as a default instead of yum, so rewrite these to use dnf. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
sync_install
branch
from
05dfdfc
to
898aa4d
Compare
dvdksn
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike deb-based systems, installing an rpm doesn't automatically start the Docker service, and starting the service doesn't make it automatically start on (re)boot. Update the instructions so that Docker is automatically started on boot. follow-up to 1514b0d, which left some of the old instructions.
Make it more clear we're starting the engine (not "docker", the CLI).
Use interactive installation for packages from our repository, so that the user can confirm what will be installed. For the distro-packages (yum-utils), we keep the non-interactive, as these should be generally ok to install. follow-up to fde4750
The versions of CentOS and RHEL we support now have dnf as a default instead of yum, so rewrite these to use dnf.
Description
Related issues or tickets
Reviews