Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
Fixes #201
What should this PR do?
Fixes the parsing issue with quotes in SPF records not being handled correctly.
Fixes the IP evaluation logic to properly understand CIDR blocks.
What are the acceptance criteria?
When loading the SPF records for
facebook.com
, the returned data for_spf.facebook.com
does not include quotation marks.When loading the SPF records for
facebook.com
,66.220.144.129
evaluates successfully, and123.456.123.456
does not.