[feat #138] 채팅방 목록 조회 API 상태 필드 추가 및 필터링 수정 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Code Coverage
|
Test Results 25 files 25 suites 14s ⏱️ Results for commit c911a70. |
dudxo
approved these changes
Nov 12, 2024
dudxo
reviewed
Nov 12, 2024
| @@ -58,11 +60,11 @@ public ResponseEntity<CreateChatRoomResponse> createChatRoom( | |||
| @Operation(summary = "채팅방 목록 조회 API", description = "회원의 채팅방 목록을 조회한다.") | |||
| @GetMapping("/api/chat-rooms") | |||
| public ResponseEntity<PageResponse<ChatRoomSimpleResponse>> getChatRoomsByMember( | |||
| @RequestParam("status") String status, | |||
| @RequestParam("statuses") List<String> statuses, | |||
There was a problem hiding this comment.
목록 조회 시 필터 기능이 있어서 추가하신건가요?
There was a problem hiding this comment.
채팅 목록 조회에 수락됨 상태의 채팅방을 표시하고,
채팅 요청 조회에 요청됨, 거절됨 상태의 채팅방을 표시하려고 추가했습니다.
상태를 파라미터로 받고 status에 대해 in절로 쿼리하면 될 것 같아서요.
There was a problem hiding this comment.
그런데 지금 피그마 확인해보니까 요청의 주체여부에 따라 표기 방법이 다르네요..
이 부분은 더 고민해보겠습니다...
There was a problem hiding this comment.
뭔가 지난 회의 때 논의가 정확하게 이루어지지 않은 것처럼 보이네요..
그땐 잘 이루어진 것처럼 느껴졌는데
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분
b7cde2e 혹시 네이버 포메터 말고 다른 포메터 사용하고 계신가요??