Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat #132] 채팅방 입장 시 요청 메시지 전송 #133

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

hyun2371
Copy link
Member

관련 이슈

📑 작업 상세 내용

  • 채팅 요청 시 요청 메시지 DB에 저장
    • 기존) 요청자가 채팅방만 생성(요청)
    • 문제) 채팅방 목록 조회 시 요청자가 메시지 하나도 보내지 않으면 NPE 발생
    • 해결) 요청자가 채팅방 생성 시 ~님이 채팅을 요청했습니다. 채팅 메시지 저장

💫 작업 요약

  • 채팅 요청 시 요청 메시지 전송

🔍 중점적으로 리뷰 할 부분

@hyun2371 hyun2371 added the ✨ feat 기능 추가 label Oct 16, 2024
@hyun2371 hyun2371 requested a review from dudxo October 16, 2024 07:53
@hyun2371 hyun2371 self-assigned this Oct 16, 2024
@hyun2371 hyun2371 linked an issue Oct 16, 2024 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Oct 16, 2024

Code Coverage

Overall Project 87.03% -0.05% 🍏
Files changed 75% 🍏

File Coverage
ChatRoomService.java 92.86% 🍏
ChatMessageService.java 10.81% -5.41%

Copy link

Test Results

 25 files   25 suites   15s ⏱️
119 tests 119 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 6724b0e.

@hyun2371 hyun2371 merged commit 95e96f3 into dev Oct 16, 2024
1 check passed
@hyun2371 hyun2371 deleted the feat/#132/chat-create-add-message branch October 16, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 채팅방 생성 시 요청 메시지 전송
2 participants