Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat #125] Aop logging #126

Merged
merged 6 commits into from
Sep 30, 2024
Merged

[feat #125] Aop logging #126

merged 6 commits into from
Sep 30, 2024

Conversation

dudxo
Copy link
Collaborator

@dudxo dudxo commented Sep 30, 2024 •
edited
Loading

관련 이슈

📑 작업 상세 내용

  • infinity page response 간소화를 위한 toString() Override
  • logging을 저장할 파일 스크립트 xml 추가

💫 작업 요약

  • AOP logging 작업

🔍 중점적으로 리뷰 할 부분

  • DB 저장 방식에서 1차적으로 파일 저장 방식으로 선택하였습니다.
  • 파일 저장 여부는 PR 시 CD 작동으로 스크립트 수정하여 잠시 테스트 해보겠습니다.
  • 배포용 yml 수정해서 업데이트 시켰습니다!

@dudxo dudxo added the ✨ feat 기능 추가 label Sep 30, 2024
@dudxo dudxo requested a review from hyun2371 September 30, 2024 12:17
@dudxo dudxo self-assigned this Sep 30, 2024
@dudxo dudxo linked an issue Sep 30, 2024 that may be closed by this pull request
✨ AOP 로깅 #125
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Test Results

 25 files   25 suites   15s ⏱️
115 tests 115 ✅ 0 💤 0 ❌
116 runs  116 ✅ 0 💤 0 ❌

Results for commit d4dea3d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 86.35% 🍏

There is no coverage information present for the Files changed

@dudxo dudxo merged commit f7ad698 into dev Sep 30, 2024
3 checks passed
@dudxo dudxo deleted the feat/#125/aop-logging branch September 30, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun2371 hyun2371 hyun2371 approved these changes

Assignees

@dudxo dudxo

Labels
✨ feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ AOP 로깅
2 participants
@dudxo @hyun2371