Allow external configuration of endianness in R package build #10642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed a couple failures here. In looking into them, am curious does this go back to On a somewhat related note, it appears |
|
Added This warning causes the R build to fail: https://github.com/dmlc/xgboost/actions/runs/10152770673/job/28074838045?pr=10642 |
hcho3
approved these changes
Jul 29, 2024
hcho3
added a commit
to hcho3/xgboost
that referenced
this pull request
Jul 30, 2024
…0642) * Allow users to set endianness in R build * Run `autoreconf -vi` * Don't use :BOOL suffix * Use AC_CONFIG_HEADERS --------- Co-authored-by: Hyunsu Cho <[email protected]> Co-authored-by: Philip Hyunsu Cho <[email protected]>
hcho3
added a commit
that referenced
this pull request
Jul 30, 2024
…ild (#10642) (#10645) * Allow external configuration of endianness in R package build (#10642) * Allow users to set endianness in R build * Run `autoreconf -vi` * Don't use :BOOL suffix * Use AC_CONFIG_HEADERS --------- Co-authored-by: Hyunsu Cho <[email protected]> Co-authored-by: Philip Hyunsu Cho <[email protected]> * Re-run roxygen2 --------- Co-authored-by: jakirkham <[email protected]>
|
Thanks Hyunsu! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework R package's
configure.acto accept and use theUSE_LITTLE_ENDIANenvironment variable. If set, this allows overriding the endianness used for the R package built. If not set, then this falls back toautoconf's own endianness check. If it is still not clear what endianness to use, the build then errors and asks for it to be specified.For more context conda-forge builds have needed to patch out the existing configuration logic for endianness and set their own value as the current check isn't always correct. This would allow the conda-forge builds to drop that patch and simply specify
USE_LITTLE_ENDIANwhen needed (a more maintainable solution).