[jvm-packages] clean up example #10618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @trivialfis @hcho3, please help review this PR which is the first small PR of #10617, thx |
trivialfis
reviewed
Jul 22, 2024
| @@ -48,6 +49,6 @@ object BoostFromPrediction { | |||
| testMat.setBaseMargin(testPred) | |||
|
|
|||
| System.out.println("result of running from initial prediction") | |||
| val booster2 = XGBoost.train(trainMat, params.toMap, 1, watches.toMap, null, null) | |||
| XGBoost.train(trainMat, params.toMap, 1, watches.toMap, null, null) | |||
There was a problem hiding this comment.
What is this example doing if it's not showing the result?
There was a problem hiding this comment.
Guess it's just trying to verify if the training is ok.
| @@ -40,7 +40,6 @@ object CrossValidation { | |||
| // set additional eval_metrics | |||
| val metrics: Array[String] = null | |||
|
|
|||
| val evalHist: Array[String] = | |||
| XGBoost.crossValidation(trainMat, params.toMap, round, nfold, metrics) | |||
| XGBoost.crossValidation(trainMat, params.toMap, round, nfold, metrics) | |||
There was a problem hiding this comment.
Since this is an example, maybe it's useful to print it?
There was a problem hiding this comment.
I would not to refine the tests in this PR. Maybe have the follow up after merging my all small PRs for reworking jvm
hcho3
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st PR of #10617