Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FutureWarning] Resolving warnings caused by deprecated function usage. #7814

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

drivanov
Copy link
Contributor

@drivanov drivanov commented Oct 2, 2024

Description

This PR provides a fix for the following warnings:

/usr/local/lib/python3.10/dist-packages/dgl/backend/pytorch/sparse.py:148: FutureWarning: `torch.cuda.amp.autocast(args...)` 
is deprecated. Please use `torch.amp.autocast('cuda', args...)` instead.
  return th.cuda.amp.autocast(enabled=False)

/usr/local/lib/python3.10/dist-packages/dgl/backend/pytorch/sparse.py:157: FutureWarning: `torch.cuda.amp.autocast_mode._cast(value, dtype)` 
is deprecated. Please use `torch.amp.autocast_mode._cast(value, 'cuda', dtype)` instead.
  return th.cuda.amp.autocast_mode._cast(

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 2, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 2, 2024

Commit ID: c047a3c

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@drivanov drivanov changed the title [FutureWarning] Fixing warning generated by the use of torch.cuda.amp.autocast* fun… [FutureWarning] Fixing warning generated by the use of torch.cuda.amp.autocast* functions. Oct 2, 2024
@drivanov drivanov changed the title [FutureWarning] Fixing warning generated by the use of torch.cuda.amp.autocast* functions. [FutureWarning] Fixing warning generated by the use of deprecated functions. Oct 2, 2024
@drivanov drivanov changed the title [FutureWarning] Fixing warning generated by the use of deprecated functions. [FutureWarning] Resolving warnings caused by deprecated function usage. Oct 2, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 2, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 2, 2024

Commit ID: 3ccc508

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 2, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 2, 2024

Commit ID: 57e2227

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 8, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 8, 2024

Commit ID: bdea2f1

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@jermainewang
Copy link
Member

Which PyTorch version is this future warning introduced?

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 10, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 10, 2024

Commit ID: 3d93fce

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@drivanov
Copy link
Contributor Author

As far as I can tell, this change was introduced on June 2, 2024:

andreii@andrei-Ubuntu:~/Projects/pytorch$ git blame -L 56,60 torch/cuda/amp/autocast_mode.py 
67ef2683d97 (Xuehai Pan 2024-06-02 07:31:08 +0000 56) @deprecated(
67ef2683d97 (Xuehai Pan 2024-06-02 07:31:08 +0000 57)     "`torch.cuda.amp.autocast_mode._cast(value, dtype)` is deprecated. "
67ef2683d97 (Xuehai Pan 2024-06-02 07:31:08 +0000 58)     "Please use `torch.amp.autocast_mode._cast(value, 'cuda', dtype)` instead.",
67ef2683d97 (Xuehai Pan 2024-06-02 07:31:08 +0000 59)     category=FutureWarning,
67ef2683d97 (Xuehai Pan 2024-06-02 07:31:08 +0000 60) )

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 16, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 16, 2024

Commit ID: 1b36681

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants