Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incorrect Javadoc #456

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Update incorrect Javadoc #456

merged 1 commit into from
Jan 8, 2024

Conversation

VirtualTim
Copy link
Contributor

@VirtualTim VirtualTim commented Jan 8, 2024 •
edited
Loading

Documented default value did not match code.

See:

PreferencesFX/preferencesfx/src/main/java/com/dlsc/preferencesfx/model/PreferencesFxModel.java

Line 57 in 6da9ef5

private boolean saveSettings = true;

And:

PreferencesFX/README.md

Line 201 in 6da9ef5

`.saveSettings` | `PreferencesFx` | Defines whether the changed settings in the Preferences window should be saved or not. Defaults to true.

@VirtualTim
Update incorrect Javadoc
858847f 
Documented default value did not match code.
@dlemmermann dlemmermann merged commit d16b20b into dlsc-software-consulting-gmbh:master-11 Jan 8, 2024
2 of 3 checks passed
@VirtualTim VirtualTim deleted the patch-2 branch January 10, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VirtualTim @dlemmermann