-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Incorrect timeout error when using FindStringMatch() #86
base: master
Are you sure you want to change the base?
Conversation
…atches will get a wrong fast.current and daeline, thus trigger an incorrect timeout error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
but I would expect some tests to be provided with the fix. It would avoid errors in any future refactoring
…atches will get a wrong fast.current and daeline, thus trigger an incorrect timeout error.
Add a new UT, If you comment the add code, the ut will failed. |
Co-authored-by: ccoVeille <[email protected]>
Thanks for submitting this. Can you add an integration-level test showing the behavior fix from the API consumer perspective? |
Add a new UT for my own case. Maybe you guys can add a more elegant test. |
@Brinenas a couple issues I see:
I did a couple other small tweaks to the test as well. Let me know if you see any issues with my change. |
fix Timeout Error issue: when the fastclock stop running, then next matches will get a wrong fast.current and daeline, thus trigger an incorrect timeout error.