Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for hasSlicing with inifnite range #8898

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Jan 20, 2024

The requirement for opSlice on an infinite range to return the result of take or takeExactly was removed in commit c828a08, which was included in Phobos 2.067.0, released in March 2015. However, the documentation was never updated to take this change into account.

This change updates the documentation and adds a unit test for the "new" behavior.

Fixes bugzilla issue 24348.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24348 normal Inaccurate documentation for hasSlicing with infinite range

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8898"

The requirement for opSlice on an infinite range to return the result of
take or takeExactly was removed in commit c828a08, which was included
in Phobos 2.067.0, released in March 2015. However, the documentation
was never updated to take this change into account.

This change updates the documentation and adds a unit test for the "new"
behavior.

Fixes bugzilla issue 24348.
@dlang-bot dlang-bot merged commit c4391b2 into dlang:master Jan 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants