This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
CRuntime_Musl: More fixes for time64 #3313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
force-pushed
the
time64-strikes-again
branch
2 times, most recently
from
c6b8fb3
to
aa50fc7
Compare
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Dec 14, 2020
Also disable dependants. LDC currently can't build on x86 because GDC is broken on x86 due to time_t changes in musl 1.2. Once dlang/druntime#3313 landed we can re-enable this.
Geod24
force-pushed
the
time64-strikes-again
branch
from
aa50fc7
to
9537a13
Compare
|
Does tsunami on BuildKite treat deprecations as errors? Otherwise I can't tell why it fails from the logs. |
It's spurious. We're coming back to this and getting it tested, stay tuned. |
PetarKirov
approved these changes
Feb 25, 2021
| // int :8*(sizeof(time_t)-sizeof(long))*(__BYTE_ORDER!=4321); | ||
| version (LittleEndian) | ||
| static if (time_t.sizeof > c_long.sizeof) | ||
| int __padding; |
There was a problem hiding this comment.
You can make the __padding as private for extra protection that is not available in C ;)
There was a problem hiding this comment.
True, but no other place in druntime do this.
omerfirmak
reviewed
Feb 25, 2021
Geod24
force-pushed
the
time64-strikes-again
branch
3 times, most recently
from
676a4a7
to
5b869f6
Compare
The original PR (dlang#3275) missed quite a few spots and conversions, which led to the build on Alpine Linux failing with Aithmetic Exception on core.time module constructor. Links to the two offending commits are included. For further issues / investigation, search for 'time64' in the git repository. Co-Authored-By: Ömer Faruk IRMAK <[email protected]>
Geod24
force-pushed
the
time64-strikes-again
branch
from
5b869f6
to
fc8b1e6
Compare
|
Is it ok to close this in favor of #3383 ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Cogitri , I'll rebuild my GDC and see if that solve LDC v1.24's issues.