Feature/compiler version #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Hrom131
commented
Oct 10, 2024
•
Hrom131
commented
- Since this PR suggests a bug fix, the relevant tests have been added.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
Arvolear
reviewed
Oct 10, 2024
| `${OLDEST_SUPPORTED_CIRCOM_VERSION} - ${LATEST_SUPPORTED_CIRCOM_VERSION}`, | ||
| ); | ||
|
|
||
| if (isVersionStrict && !semver.satisfies(version, supportedVersionsRange!)) { |
There was a problem hiding this comment.
Why only when the version is strict?
Also there are js comments that need to be fixed.
There was a problem hiding this comment.
We may have a case where there is a version in the circuit, for example 2.0.0 and no version is set in the config. In this case we don't have a strict version and we will take the maximum supported version. Without this check, we will get an error that the version is not supported and should be within 2.0.5 - 2.1.9.
There was a problem hiding this comment.
But what if the circuit has pragma 2.2.0 inside? Currently this version is not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.